jotbe/ansible-role-jitsi-docker
1
0
Fork 0
Code Issues 1 Pull requests 1 Releases Wiki Activity

feature/latest-upstream-docker-compose #2

Merged
jotbe merged 9 commits from feature/latest-upstream-docker-compose into master 2022-10-03 00:59:35 +02:00
Conversation 1 Commits 9 Files changed 9 +445 -297
jotbe commented 2020-12-13 00:37:07 +01:00
Owner
Copy link
No description provided.
jsydll reviewed 2020-12-13 13:21:14 +01:00
templates/docker-compose.jitsi.yml.j2 Outdated
@ -17,2 +54,3 @@
- ENABLE_TCC
- ENABLE_TRANSCRIPTIONS
- DISABLE_HTTPS
- ENABLE_XMPP_WEBSOCKET
jsydll commented 2020-12-13 13:21:14 +01:00
Collaborator
Copy link

For some env vars like this one, there are no entries/descriptions in the env.example from upstream Jitsi repo. Using the existing .env file will lead to default values here - but I like this preparatory step.

For some env vars like this one, there are no entries/descriptions in the `env.example` from upstream Jitsi repo. Using the existing `.env` file will lead to default values here - but I like this preparatory step.
jotbe marked this conversation as resolved
jsydll reviewed 2020-12-13 13:27:35 +01:00
templates/docker-compose.jitsi.yml.j2 Outdated
@ -177,1 +232,4 @@
meet.jitsi:
labels:
traefik.udp.routers.jvb.entrypoints: video
traefik.udp.routers.jvb.service: jvb
jsydll commented 2020-12-13 13:27:35 +01:00
Collaborator
Copy link

What's the purpose of the service dict var?

What's the purpose of the service dict var?
jotbe commented 2020-12-13 14:16:29 +01:00
Author
Owner
Copy link

This should define a service entity for traefik which allows e.g. for loadbalancing. I haven't tried the loadbalancing yet. On the other hand, that entrypoint video is not further defined here. I am not sure whether other configuration is missing here.

This should define a service entity for traefik which allows e.g. for loadbalancing. I haven't tried the loadbalancing yet. On the other hand, that entrypoint `video` is not further defined here. I am not sure whether other configuration is missing here.
jsydll commented 2020-12-13 14:31:23 +01:00
Collaborator
Copy link

As long as this does not break our current setup, I'm fine with having the new labels here.

As long as this does not break our current setup, I'm fine with having the new labels here.
jotbe marked this conversation as resolved
jsydll reviewed 2020-12-13 13:28:08 +01:00
templates/docker-compose.jitsi.yml.j2 Outdated
@ -178,0 +233,4 @@
labels:
traefik.udp.routers.jvb.entrypoints: video
traefik.udp.routers.jvb.service: jvb
traefik.udp.services.jvb.loadbalancer.server.port: '10000'
jsydll commented 2020-12-13 13:28:08 +01:00
Collaborator
Copy link

Could that be parameterized with ${JVB_PORT}?

Could that be parameterized with `${JVB_PORT}`?
jotbe commented 2020-12-13 14:22:09 +01:00
Author
Owner
Copy link

Good point! Yes, could be, but it makes sense to create an Ansible var to allow a config of that JVB_PORT which is still more or less hardcoded in the env file.

Good point! Yes, could be, but it makes sense to create an Ansible var to allow a config of that `JVB_PORT` which is still more or less hardcoded in the env file.
jsydll commented 2020-12-13 14:29:56 +01:00
Collaborator
Copy link

To my knowledge, this variable already exists: jitsi_bridge_udp_port. Or do I mix up things here?

To my knowledge, this variable already exists: `jitsi_bridge_udp_port`. Or do I mix up things here?
jotbe commented 2020-12-13 17:50:29 +01:00
Author
Owner
Copy link

Where is that? I cannot find that string in the code.

Where is that? I cannot find that string in the code.
jsydll commented 2020-12-14 07:34:25 +01:00
Collaborator
Copy link

I'm sorry, got that mixed up with one of my branches where I also needed to introduce such a variable :D

I'm sorry, got that mixed up with one of my branches where I also needed to introduce such a variable :D
jotbe marked this conversation as resolved
jsydll commented 2020-12-13 13:30:11 +01:00
Collaborator
Copy link

Memo for myself: This creates conflicts with the upcoming PR on multitenancy.

Memo for myself: This creates conflicts with the upcoming PR on multitenancy.
jotbe added 3 commits 2022-10-02 22:27:44 +02:00
jotbe merged commit 60a595c388 into master 2022-10-03 00:59:35 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jotbe/ansible-role-jitsi-docker#2
No description provided.
Delete branch "feature/latest-upstream-docker-compose"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?